Add error helpers and update README feature table#79
Merged
Conversation
The feature flags table was missing 7 features that exist in Cargo.toml: signatures-es384, signatures-rsa, encryption-chacha, key-wrapping, key-wrapping-rsa, key-wrapping-pbes2, and webauthn. Also updated the algorithm summary line to mention ES384, PS256, and ML-DSA-65.
Reduces boilerplate across security modules by introducing pub(crate) helper functions (invalid_manifest, encryption_error, network_error, invalid_certificate) that replace 55+ verbose inline map_err closures with concise one-liners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pub(crate)error helper functions (invalid_manifest,encryption_error,network_error,invalid_certificate) toerror.rsmap_errclosures across 9 security modules with concise helper calls — net reduction of 106 linessignatures-es384,signatures-rsa,encryption-chacha,key-wrapping,key-wrapping-rsa,key-wrapping-pbes2,webauthn)Test plan
cargo build --workspace --all-featurespassescargo test --workspace --all-featurespasses (949 tests)cargo clippy --workspace --all-features -- -D warningspasses (0 warnings)