Skip to content

fix: resolve console warnings and race conditions#14

Merged
gvonness-apolitical merged 1 commit intomainfrom
fix/console-warnings
Feb 3, 2026
Merged

fix: resolve console warnings and race conditions#14
gvonness-apolitical merged 1 commit intomainfrom
fix/console-warnings

Conversation

@gvonness-apolitical
Copy link
Copy Markdown
Collaborator

Summary

  • Fix CBZ/PDF reader race conditions when component destroyed during async operations
  • Fix Lit update cycle warning by deferring initReader with queueMicrotask
  • Fix aria-hidden focus warning by using inert attribute alone (removes redundant aria-hidden)
  • Add focus management to TOC panel to move focus out before panel closes
  • Add guards for all state property changes to avoid unnecessary re-renders

Test plan

  • Load EPUB, navigate through TOC - no aria-hidden warnings
  • Load Tumblr post via button - no Lit update cycle warning
  • Rapidly switch between formats - no race condition errors
  • All 124 tests pass
  • Build succeeds

- Fix CBZ/PDF reader race conditions when component destroyed during async ops
- Fix Lit update cycle warning by deferring initReader with queueMicrotask
- Fix aria-hidden focus warning by using inert attribute alone
- Add focus management to TOC panel to move focus before close
- Add guards for all state property changes to avoid unnecessary re-renders
@gvonness-apolitical gvonness-apolitical merged commit 4b68f91 into main Feb 3, 2026
3 checks passed
@gvonness-apolitical gvonness-apolitical deleted the fix/console-warnings branch February 3, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant