refactor: extract BaseVisualReader for common zoom/fit/layout#16
Merged
gvonness-apolitical merged 1 commit intomainfrom Feb 3, 2026
Merged
refactor: extract BaseVisualReader for common zoom/fit/layout#16gvonness-apolitical merged 1 commit intomainfrom
gvonness-apolitical merged 1 commit intomainfrom
Conversation
- Create BaseVisualReader extending BaseReader with shared state management - Move zoomLevel, fitMode, layoutMode, cachedToc to base class - Implement common getZoom, setZoom, getFitMode, setFitMode, getLayout, setLayout - Add abstract onDisplayChange() for subclass-specific re-rendering - Update PDF, CBZ, and EPUB readers to extend BaseVisualReader - Removes ~100 lines of duplicate code across readers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts common zoom, fit mode, layout mode, and TOC state management into a shared
BaseVisualReaderbase class, reducing code duplication across PDF, CBZ, and EPUB readers.Changes
Create
BaseVisualReaderextendingBaseReaderwith:zoomLevel,fitMode,layoutMode,cachedTocgetZoom,setZoom,getFitMode,setFitMode,getLayout,setLayoutonDisplayChange()for subclass-specific re-renderinggoToTocItem()for format-specific TOC navigationgetToc()returning cached TOCUpdate readers to extend
BaseVisualReader:onDisplayChange()to callrenderPage(currentPage)onDisplayChange()to callrenderPage(currentPageNum)onDisplayChange()to callapplyZoom()andapplyLayout()Impact
Test plan