Update AdjointGenerator.h with maximum and minimum intrinsics #1200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you add a forward and reverse mode ll test? (look inside repo/enzyme/test/ReverseMode/ and repo/enzyme/test/ForwardMode). |
Contributor
Author
|
Added a couple of tests @wsmoses |
wsmoses
reviewed
May 16, 2023
Contributor
Author
|
How's that look @wsmoses ? |
tgymnich
reviewed
May 24, 2023
Contributor
Author
|
Along similar lines, is maxnum.ll correct in forward mode? |
Member
|
@motabbara are you able to see the results of CI or run the tests locally? I'm fine to merge as soon as the pass (and as a consequence test for the correct result :P ) |
wsmoses
reviewed
May 29, 2023
wsmoses
reviewed
May 29, 2023
Contributor
Author
|
@tgymnich don't think this will get auto-merged while CI pipeline is still in flux. Can you please manually merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.