Skip to content

Fix string usage #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tgymnich merged 4 commits into from
Jun 10, 2023
Merged

Fix string usage #1272

tgymnich merged 4 commits into from
Jun 10, 2023

Conversation

@tgymnich
Copy link
Member

@tgymnich tgymnich commented Jun 10, 2023 •
edited
Loading

std::map<std::string, T> --> StringMap<T>
std::set<std::string> --> StringSet<>

Additionally replace std::string in function signatures with StringRef and avoid materialising std::strings where possible

tgymnich
tgymnich commented Jun 10, 2023
View reviewed changes
@tgymnich tgymnich self-assigned this Jun 10, 2023
@tgymnich tgymnich marked this pull request as ready for review June 10, 2023 17:13
@tgymnich tgymnich merged commit 9b81bac into main Jun 10, 2023
@tgymnich tgymnich deleted the fix-string-usage branch June 10, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wsmoses wsmoses wsmoses approved these changes

Assignees

@tgymnich tgymnich

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tgymnich @wsmoses