Skip to content

Conversation

@ZuseZ4
Copy link
Collaborator

@ZuseZ4 ZuseZ4 commented Jul 1, 2023

No description provided.

@ZuseZ4 ZuseZ4 marked this pull request as ready for review July 1, 2023 08:22
@ZuseZ4 ZuseZ4 requested a review from wsmoses July 2, 2023 07:35
@ZuseZ4
Copy link
Collaborator Author

ZuseZ4 commented Jul 2, 2023

We now avoid the double free of matrices,
have less cases where we emit strange blas declarations (in case that we pass constant floats),
and can allocate tmp vectors or matrices for nested rules.
I'll update the two scalar gemv/gemm tests tmrw

@ZuseZ4 ZuseZ4 merged commit 3053960 into main Jul 6, 2023
@ZuseZ4 ZuseZ4 deleted the nested-tg-rules branch July 6, 2023 05:41
@wsmoses
Copy link
Member

wsmoses commented Jul 6, 2023

@ZuseZ4 this broke macos CI if you can fix those tests?

@ZuseZ4
Copy link
Collaborator Author

ZuseZ4 commented Jul 6, 2023

@wsmoses Sure. I tried to find yesterday where those mac runners got stuck, but I couldn't find them in the github action window, so I had to merge without waiting for them.

MilesCranmer pushed a commit to MilesCranmer/Enzyme that referenced this pull request Jul 24, 2024
* Err and correctly handle complex returns in reverse mode

* Update index.md

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants