Skip to content

Conversation

@ZuseZ4
Copy link
Collaborator

@ZuseZ4 ZuseZ4 commented Jul 16, 2023

hasDiffeRet is the only function used in both tblgen codes and it's only 15 lines.
Let's split those two up, since we don't expect more overlap in the future.

@ZuseZ4 ZuseZ4 requested a review from tgymnich July 16, 2023 19:09
@ZuseZ4 ZuseZ4 enabled auto-merge (squash) July 16, 2023 19:10
@ZuseZ4 ZuseZ4 disabled auto-merge July 16, 2023 21:43
@ZuseZ4 ZuseZ4 enabled auto-merge (squash) July 16, 2023 21:54
@ZuseZ4 ZuseZ4 merged commit 3c71081 into main Jul 16, 2023
@ZuseZ4 ZuseZ4 deleted the split-tblgen branch July 16, 2023 22:10
MilesCranmer pushed a commit to MilesCranmer/Enzyme that referenced this pull request Jul 24, 2024
* Add import frule functionality

* Add wip rrule importer

* move everything to extension; add tests frule

* remove import_rrule

* runtests

* esc(fn) fixes tests

* added failing batchduplicated test

* remove test import

* address review comments

* add dollar in macro

* cleanup

* Fixup and cleanup

---------

Co-authored-by: William S. Moses <gh@wsmoses.com>
Co-authored-by: Billy Moses <wmoses@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants