Bugfix: Region Outlining Primal Args#2559
Merged
vimarsh6739 merged 2 commits intomainfrom Nov 15, 2025
Merged
Conversation
vimarsh6739
changed the title
vimarsh6739
force-pushed
the
fixoutline
branch
from
8463091 to
67cc708
Compare
pengmai
approved these changes
Nov 15, 2025
pengmai
reviewed
Nov 15, 2025
Member
pengmai
left a comment
pengmai
left a comment
There was a problem hiding this comment.
It looks like the new test is failing (both in CI and I've verified it locally). The suggestions should fix them
Co-authored-by: Jacob Mai Peng <jacobmpeng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't re-add primal inputs as const args