Skip to content

[CI] Run job updating MLIR bindings on Julia v1.11 #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
Merged

[CI] Run job updating MLIR bindings on Julia v1.11 #1613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73f57e5
[CI] Run job updating MLIR bindings on Julia v1.11
giordano Sep 1, 2025
5153f23
Temporarily point `Clang` to Billy's branch in `deps/ReactantExtra`
giordano Sep 1, 2025
84a3cfd
Fix formatting in optional attributes handling
wsmoses Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/regenerate-mlir-bindings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
steps:
- uses: julia-actions/setup-julia@v2
with:
version: '1.10'
version: '1.11'
- uses: julia-actions/cache@v2
- uses: bazel-contrib/setup-bazel@0.15.0
name: Set up Bazel
Expand Down
3 changes: 3 additions & 0 deletions deps/ReactantExtra/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@ BinaryBuilderBase = "7f725544-6523-48cd-82d1-3fa08ff4056e"

[compat]
Clang = "0.18"

[sources]
Clang = {url = "https://github.com/wsmoses/Clang.jl", rev = "patch-1"}
2 changes: 1 addition & 1 deletion deps/ReactantExtra/tblgen/jl-generators.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ end

if (optional) {
optionals += llvm::formatv(
R"(!isnothing({0}) && push!(attributes, namedattribute("{0}", {1}))
R"(!isnothing({1}) && push!(attributes, namedattribute("{0}", {1}))
)",
attributename, sanitizedname);
defaultvalue = "=nothing";
Expand Down
Loading