-
Notifications
You must be signed in to change notification settings - Fork 38
Specialize transpose! and adjoint! for AnyTracedRMatrix #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6a946b5 to
0fd5887
Compare
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1621 +/- ##
==========================================
- Coverage 42.07% 39.99% -2.09%
==========================================
Files 123 124 +1
Lines 21633 25369 +3736
==========================================
+ Hits 9103 10147 +1044
- Misses 12530 15222 +2692 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0fd5887 to
5b152ff
Compare
|
Thanks @avik-pal! I added the tests. |
|
Good to merge, @avik-pal ? |
|
test failures are unrelated. @wsmoses do you know what this is? Failed to precompile EnzymeCoreExt [c3ed20f3-746d-5a71-99a7-df1cca8c2b90] to "/home/runner/.julia/compiled/v1.10/EnzymeCoreExt/jl_aSA4HK".
julia: /home/runner/work/Reactant.jl/Reactant.jl/julia/src/gc.c:1289: jl_gc_pool_alloc_inner: Assertion `jl_atomic_load_relaxed(&ptls->gc_state) == 0' failed. |
|
@avik-pal when should JuliaFormatter be used (for which files in Reactant) currently? |
|
No I don't know what's up there |
pin JuliaFormatter to v1. v2 introduces quite a few strange formatting qwirks |
Thanks! |
Fixes #1611
@wsmoses where should tests for this go?