Skip to content

Conversation

@oschulz
Copy link
Contributor

@oschulz oschulz commented Sep 3, 2025

Fixes #1611

@wsmoses where should tests for this go?

@avik-pal
Copy link
Collaborator

avik-pal commented Sep 3, 2025

test/integration/linear_algebra.jl

@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.99%. Comparing base (8b740cc) to head (0e8a1d1).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1621      +/-   ##
==========================================
- Coverage   42.07%   39.99%   -2.09%     
==========================================
  Files         123      124       +1     
  Lines       21633    25369    +3736     
==========================================
+ Hits         9103    10147    +1044     
- Misses      12530    15222    +2692     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oschulz
Copy link
Contributor Author

oschulz commented Sep 3, 2025

Thanks @avik-pal!

I added the tests.

@oschulz
Copy link
Contributor Author

oschulz commented Sep 4, 2025

Good to merge, @avik-pal ?

@avik-pal
Copy link
Collaborator

avik-pal commented Sep 4, 2025

test failures are unrelated.

@wsmoses do you know what this is?

https://github.com/EnzymeAD/Reactant.jl/actions/runs/17463707754/job/49594263477?pr=1621#step:11:1525

Failed to precompile EnzymeCoreExt [c3ed20f3-746d-5a71-99a7-df1cca8c2b90] to "/home/runner/.julia/compiled/v1.10/EnzymeCoreExt/jl_aSA4HK".
julia: /home/runner/work/Reactant.jl/Reactant.jl/julia/src/gc.c:1289: jl_gc_pool_alloc_inner: Assertion `jl_atomic_load_relaxed(&ptls->gc_state) == 0' failed.

@avik-pal avik-pal merged commit f7047d4 into EnzymeAD:main Sep 4, 2025
67 of 72 checks passed
@oschulz
Copy link
Contributor Author

oschulz commented Sep 4, 2025

@avik-pal when should JuliaFormatter be used (for which files in Reactant) currently?

@wsmoses
Copy link
Member

wsmoses commented Sep 4, 2025

No I don't know what's up there

@avik-pal
Copy link
Collaborator

avik-pal commented Sep 4, 2025

@avik-pal when should JuliaFormatter be used (for which files in Reactant) currently?

pin JuliaFormatter to v1. v2 introduces quite a few strange formatting qwirks

@oschulz
Copy link
Contributor Author

oschulz commented Sep 6, 2025

pin JuliaFormatter to v1. v2 introduces quite a few strange formatting qwirks

Thanks!

@oschulz oschulz deleted the transpose-fix branch September 9, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

copy of transpose fails due to scalar indexing

3 participants