Skip to content

Fix abstract array eltype #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

Fix abstract array eltype #1807

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41bbcf1
Don't mark nospecialize if type var is captured
wsmoses Oct 30, 2025
9a3580f
fix
wsmoses Oct 30, 2025
28993ee
Apply suggestions from code review
wsmoses Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Tracing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ Base.@nospecializeinfer function traced_type_inner(
end

Base.@nospecializeinfer function traced_type_inner(
@nospecialize(A::Type{AbstractArray{T}}),
A::Type{AbstractArray{T}},
seen,
mode::TraceMode,
@nospecialize(track_numbers::Type),
Expand All @@ -455,15 +455,15 @@ Base.@nospecializeinfer function traced_type_inner(
) where {T}
if mode == ConcreteToTraced
return AbstractArray{
traced_type_inner(T, seen, mode, track_numbers, sharding, runtime)
traced_type_inner(eltype(A), seen, mode, track_numbers, sharding, runtime)
}
else
return A
end
end

Base.@nospecializeinfer function traced_type_inner(
@nospecialize(A::Type{AbstractArray{T,N}}),
A::Type{AbstractArray{T,N}},
seen,
mode::TraceMode,
@nospecialize(track_numbers::Type),
Expand All @@ -472,7 +472,8 @@ Base.@nospecializeinfer function traced_type_inner(
) where {T,N}
if mode == ConcreteToTraced
return AbstractArray{
traced_type_inner(T, seen, mode, track_numbers, sharding, runtime),N
traced_type_inner(eltype(A), seen, mode, track_numbers, sharding, runtime),
ndims(A),
}
else
return A
Expand Down
Loading