feat: more linear algebra operations (non factorization changes) #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Nov 18, 2025
src/TracedRArray.jl
Outdated
|
|
||
| # Base.first is very common usecase for getting first element to get the type | ||
| # inside LinearAlgebra.jl | ||
| Base.first(x::TracedRArray{T,N}) where {T,N} = @allowscalar(x[1]) |
Member
There was a problem hiding this comment.
do we want to put the allowscalar here? I would've expected not (but we look to what gpuarrays do)
Collaborator
Author
There was a problem hiding this comment.
let me remove this and check if anything breaks. I ended up wrapping more of the functionality manually (mostly because of conditionals)
wsmoses
approved these changes
Nov 18, 2025
avik-pal
commented
Nov 18, 2025
avik-pal
force-pushed
the
ap/more_linalg_coverage_part2
branch
from
2d4485f to
ba3251a
Compare
* refactor: move LU into a separate file * feat: lower cholesky * feat: lowering cholesky ldiv * test: cholesky * fix: revert change to is symm/hermitian
avik-pal
force-pushed
the
ap/more_linalg_coverage_part2
branch
from
d6b5975 to
9b183f4
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
factorization ops are a bit messed up upstream, need to polish those before supporting them.
det/logabsdetinvcrossrmul!,lmul!,rdiv!,ldiv!-- array and numbernormalize/normalize!(via__normalize!)normissymmetric,ishermitian,isbanded(by extensionisdiag)choleskyNon Linear Algebera additions
nextfloatprevfloat