feat: cholesky decomposition #1884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
approved these changes
Nov 18, 2025
avik-pal
force-pushed
the
ap/more_linalg_coverage_part2
branch
from
2d4485f to
ba3251a
Compare
avik-pal
force-pushed
the
ap/fact_coverage_2
branch
from
4244e5b to
3ebe043
Compare
avik-pal
merged commit b9648db
into
ap/more_linalg_coverage_part2
38 of 63 checks passed
avik-pal
added a commit
that referenced
this pull request
Nov 18, 2025
* feat: add cheaper det/logabsdet if triangular * feat: lowering of inv * fix: accidental promotion in norm * feat: support cross * feat: symmetric/hermitian/banded check * feat: normalize/normalize\! * Apply suggestion from @avik-pal * feat: cholesky decomposition (#1884) * refactor: move LU into a separate file * feat: lower cholesky * feat: lowering cholesky ldiv * test: cholesky * fix: revert change to is symm/hermitian * fix: overload normalize * test: use low cond number matrix * Update test/integration/linear_algebra.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.