feat: lower SVD to enzymexla ops #1889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
avik-pal
force-pushed
the
ap/svd_op_coverage
branch
from
a8ffbf6 to
5615e7c
Compare
avik-pal
force-pushed
the
ap/svd_op_coverage
branch
from
5615e7c to
937641c
Compare
wsmoses
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renaming the
Generalized*toBatched*. There is a distinct thing callGeneralizedSVD, hence having the old naming would be confusing.needs an upstream fix, GPU and TPU returns V instead of Vt
tests should pass once we have the JLL from EnzymeAD/Enzyme-JAX#1632