-
Notifications
You must be signed in to change notification settings - Fork 39
Add docs page on GPU kernel compilation and raising #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1920 +/- ##
==========================================
- Coverage 68.16% 64.75% -3.41%
==========================================
Files 109 124 +15
Lines 11779 13439 +1660
==========================================
+ Hits 8029 8703 +674
- Misses 3750 4736 +986 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey all, indeed a doc about raising may be interesting but a kernel part may be as important, I think RArray auto trigger CUDABackend on KA which mean without raising it may only work on CUDA, a thing to test is when not raising, setting the backend of KA by hand and the Reactant backend too but not sure Reactant will be able to send the Metal or AMD device code to the XLA backend anyway. |
|
So, as I understand it:
In light of this, should we wait for this to be fixed or should we document the behavior that we know for sure works across platforms? |
#1923 would fix this for KA kernels, it should already work for CUDA.jl kernels. |
|
Thanks! From what I see, the fix lives in Reactant's CUDA extension, so it will remain necessary to run |
|
Yes it uses CUDA.jl to extract the kernel IR. So it will need to be loaded (either by the user or the KA Reactant extension)
@wsmoses do you know how we can achieve that? |
|
By making CUDA a hard dep of Reactant? Why isn't that the case if you need it for kernels? |
|
I understand the need to keep it as a weak dep though, and I don't think Pkg manipulations should be performed under the hood. So the current error message might be good enough, I was just a bit surprised that installing CUDA on my Mac would actually solve the issue (which it did). |
We need for CUDA kernels and KA kernels, so it can be fair to require |
|
@gdalle with the other raising PR in, can you rebase this on that |
Following the docs PR invitation in https://discourse.julialang.org/t/kernelabstractions-cuda-reactant-how-to-get-minimal-working-example/134164/