Fix dense elements attribute in Enzyme.autodiff #593
#604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like I uncovered another bug? This seems to fix my issue in Tenet |
|
Seems so, can you extract the unoptimized mlir, and make an issue on EnzymeJaX with the required passes for it to err? |
|
Fixed in EnzymeAD/Enzyme-JAX#272 Just need to update the commit, build and retest |
Closed
wsmoses
force-pushed
the
ss/fix/denselementsattr-autodiff
branch
from
94160cd to
bc0a683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #593
(I still have a problem with rev-rule that i wasn't having before but that's probably on my side)