Skip to content

Fix dense elements attribute in Enzyme.autodiff #593 #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Fix dense elements attribute in Enzyme.autodiff #593 #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bd93fe
Fix #593
mofeing Jan 24, 2025
bc0a683
Add test
mofeing Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Interpreter.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,9 @@ function overload_autodiff(
act = act_from_type(A, reverse, needs_primal(CMode))
push!(ret_activity, act)
if act == enzyme_out || act == enzyme_outnoneed
attr = fill(MLIR.IR.Attribute(unwrapped_eltype(a)(1)), Ops.mlir_type(a))
attr = MLIR.IR.DenseElementsAttribute(
fill(one(unwrapped_eltype(a)), size(a))
)
cst = MLIR.IR.result(MLIR.Dialects.stablehlo.constant(; value=attr), 1)
push!(ad_inputs, cst)
end
Expand Down
12 changes: 12 additions & 0 deletions test/autodiff.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,15 @@ end
res2 = @jit ddf(x)
@test res2 ≈ 4 * 3 * 3.1^2
end

@testset "Seed initialization of Complex arrays on matmul: Issue #593" begin
a = ones(ComplexF64, 2, 2)
b = 2.0 * ones(ComplexF64, 2, 2)
a_re = Reactant.to_rarray(a)
b_re = Reactant.to_rarray(b)
df(x, y) = Enzyme.gradient(ReverseWithPrimal, *, x, y)
res = @jit df(a_re, b_re) # before, this segfaulted
@test res.val ≈ 4ones(2, 2)
@test res.derivs[1] ≈ 4ones(2, 2)
@test res.derivs[2] ≈ 2ones(2, 2)
end
Loading