Throw an error when generating a large constant #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Mar 8, 2025
giordano
force-pushed
the
mg/error-large-constant
branch
from
ac0b1c9 to
6374b72
Compare
wsmoses
reviewed
Mar 8, 2025
src/Ops.jl
Outdated
| @noinline function constant( | ||
| x::DenseArray{T,N}; location=mlir_stacktrace("constant", @__FILE__, @__LINE__) | ||
| ) where {T,N} | ||
| sizeof(x) > LARGE_CONSTANT_THRESHOLD[] || error(""" |
Member
There was a problem hiding this comment.
Probably you want lebngth not sizeof
Member
Author
There was a problem hiding this comment.
sizeof gives the size in bytes, length would be type-dependent, I thought the former would be more interesting.
Member
There was a problem hiding this comment.
Yeah fair enough, from other projects I just have too many eltypes that may not have a defined size, but here we need to have that
giordano
force-pushed
the
mg/error-large-constant
branch
2 times, most recently
from
8f57652 to
c34dd36
Compare
giordano
force-pushed
the
mg/error-large-constant
branch
from
c34dd36 to
854dbb2
Compare
giordano
force-pushed
the
mg/error-large-constant
branch
from
854dbb2 to
a0d3d44
Compare
wsmoses
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.