Skip to content

[ReactantExtra] Fix mlirOperationParse and add mlirOperationInject #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

[ReactantExtra] Fix mlirOperationParse and add mlirOperationInject #879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f5d666
[ReactantExtra] Fix `mlirOperationParse` and add `mlirOperationInject`
mofeing Mar 11, 2025
6a305e7
Apply suggestions from code review
mofeing Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions deps/ReactantExtra/API.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,26 @@ extern "C" MlirAttribute mlirComplexAttrDoubleGetChecked(MlirLocation loc,
unwrap(loc), cast<ComplexType>(unwrap(type)), real, imag));
}

extern "C" MlirOperation mlirOperationParse(MlirContext ctx,
MlirStringRef code) {
ParserConfig config(unwrap(ctx));
OwningOpRef<Operation *> owning_op = parseSourceString(unwrap(code), config);
if (!owning_op)
extern "C" bool mlirOperationInject(MlirContext ctx, MlirBlock block,
MlirStringRef code, MlirLocation location,
bool verify_after_parse) {
ParserConfig config(unwrap(ctx), verify_after_parse);
if (failed(parseSourceString(unwrap(code), unwrap(block), config)))
return false;
return true;
}

extern "C" MlirOperation mlirOperationParse(MlirContext ctx, MlirBlock block,
MlirStringRef code,
MlirLocation location,
bool verify_after_parse) {
ParserConfig config(unwrap(ctx), verify_after_parse);
if (failed(parseSourceString(unwrap(code), unwrap(block), config)))
return MlirOperation{nullptr};
return MlirOperation{owning_op.release()};
return MlirOperation{
mlir::detail::constructContainerOpForParserIfNecessary<Operation *>(
unwrap(block), config.getContext(), unwrap(location))
.release()};
}

// TODO mlirComplexAttrGetnValue
Expand Down
Loading