154 add gnn outputs into color ssn#155
Merged
Merged
Conversation
- Post-processes colored SSN to insert GNT data - GNT data (present/neighbors/ID/neighbor families) is added after cluster number - Data comes from GND - GND schema moved to separate module and GND reader created so that updated pipeline can use data
- Move coloring to script in each pipeline - Colors assigned in the shared color workflow - This allows the GNT pipeline to process the SSN only once instead of twice (once by the color SSN shared pipeline and once in the GNT to add the GNT attributes
rbdavid
approved these changes
Apr 15, 2025
Contributor
rbdavid
left a comment
rbdavid
left a comment
There was a problem hiding this comment.
Approved with very minor comments and questions.
I sound like a broken record in my comments. I think I caught the different areas of the codes where UniRef functionality is to be added for the GNT. Is documentation of those spots important for the #111 issue (or sub-issues that might spawn from there)?
This was referenced Apr 16, 2025
This was
linked to
issues
Apr 18, 2025
This was
unlinked from
issues
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added GNN outputs to the color SSN. This required a significant refactoring of the way SSNs were processed in the shared Color SSN pipeline. Additionally, the missing pieces for the GNDs were added (by necessity for the new node attributes). This should not conflict with existing PRs.