Skip to content

Model transfer hotfix#84

Draft
nicholebarry wants to merge 24 commits intomainfrom
model_transfer_hotfix
Draft

Model transfer hotfix#84
nicholebarry wants to merge 24 commits intomainfrom
model_transfer_hotfix

Conversation

@nicholebarry
Copy link
Copy Markdown
Collaborator

@nicholebarry nicholebarry commented Apr 20, 2026

Model Transfer

Fixes the time handling of transferred model visibilities for proper time matching to the data. Fixes #68

Also fixes various comments and error messages which were either wrong or vague.

Types of Changes

  • Bug Fixes

Changelog

Bug Fixes

Checklist

General PR Checklist

  • I have the read the contribution guide
  • Add all the above to the Changelog into the unreleased section

Bug Fixes Checklist

  • Added all bug fixes with any issues associated with them linked.
  • Added new tests to cover bugs
  • Adjusted existing tests to cover bug, in which case check the Existing Tests Checklist

Documentation Checklist

  • The documentation is able to build successfully with any new changes and they are visible in your own build

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 32.47232% with 183 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.90%. Comparing base (4c11ade) to head (ed680d7).

Files with missing lines Patch % Lines
PyFHD/beam_setup/antenna.py 0.00% 59 Missing ⚠️
PyFHD/pyfhd_tools/pyfhd_setup.py 30.50% 31 Missing and 10 partials ⚠️
PyFHD/beam_setup/beam.py 0.00% 19 Missing ⚠️
PyFHD/source_modeling/vis_model_transfer.py 66.66% 12 Missing and 5 partials ⚠️
PyFHD/healpix/healpix_utils.py 16.66% 13 Missing and 2 partials ⚠️
PyFHD/data_setup/obs.py 62.06% 11 Missing ⚠️
PyFHD/beam_setup/beam_utils.py 0.00% 9 Missing ⚠️
PyFHD/io/pyfhd_io.py 53.84% 5 Missing and 1 partial ⚠️
PyFHD/healpix/export.py 0.00% 3 Missing ⚠️
PyFHD/calibration/vis_calibrate_subroutine.py 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   32.74%   32.90%   +0.15%     
==========================================
  Files          27       26       -1     
  Lines        5540     5574      +34     
  Branches     1012     1024      +12     
==========================================
+ Hits         1814     1834      +20     
- Misses       3525     3529       +4     
- Partials      201      211      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nicholebarry nicholebarry force-pushed the model_transfer_hotfix branch from ee37f90 to ed680d7 Compare April 22, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong time handling for FHD sav files

2 participants