Draft
Conversation
specifically, resulted in a gridding kernel that did not contain the actual beam
plus fixes to make LWA beams & data work
better handling without metafits, fix bugs with antenna number handling and handling for more than 128 antennas
to avoid confusion with the new `uvbeam-file-path`
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 32.74% 32.90% +0.15%
==========================================
Files 27 26 -1
Lines 5540 5574 +34
Branches 1012 1024 +12
==========================================
+ Hits 1814 1834 +20
- Misses 3525 3529 +4
- Partials 201 211 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ee37f90 to
ed680d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model Transfer
Fixes the time handling of transferred model visibilities for proper time matching to the data. Fixes #68
Also fixes various comments and error messages which were either wrong or vague.
Types of Changes
Changelog
Bug Fixes
Checklist
General PR Checklist
Bug Fixes Checklist
Documentation Checklist