Frontend - Provide default values to avoid potential NAN value returned when using dynamic player aspect ratios#167
Merged
lukehb merged 1 commit intoEpicGamesExt:masterfrom Jul 10, 2024
Conversation
richardFocus
changed the title
lukehb
added
auto-backport
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
What problem does this PR address?
Our app uses various UI layouts for different pages and the pixel streaming player resizes to fit the available space as needed. Currently there is an issue in the where the value of the X mouse coord in CoordinateConverter.tsx can return NAN. I have found this to happen when the stream first starts and when the player hasn't yet resized and therefore could be zero, however resizing the player to zero width could also cause similar issues.
Solution
How does this PR solve the problem?
The PR provides temporary default values that are divisible and prevents NAN from being returned.
Documentation
If you added a new feature or changed an existing feature please add some documentation here.
Or better yet, link to the relevant
/Docsupdate in your PR.Test Plan and Compatibility
What steps have you taken to ensure this PR maintains compatibility with the existing functionality?
I have printed the returning value to the screen from every possible combination of layouts I have available.
Or better yet, link to the unit tests that accompany this PR.