Skip to content

Disconnect flow fixes#197

Merged
mcottontensor merged 3 commits intoEpicGamesExt:masterfrom
mcottontensor:disconnect_flow
Jul 17, 2024
Merged

Disconnect flow fixes#197
mcottontensor merged 3 commits intoEpicGamesExt:masterfrom
mcottontensor:disconnect_flow

Conversation

@mcottontensor
Copy link
Copy Markdown
Collaborator

@mcottontensor mcottontensor commented Jul 16, 2024

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

Certain situations allowed the click to restart stream message to be omitted or added when they shouldn't be.

Solution

Better handling of the disconnect/reconnect states

Fixes #176

@mcottontensor mcottontensor marked this pull request as ready for review July 16, 2024 23:11
Copy link
Copy Markdown
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukehb lukehb added auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.4 Auto backport to UE 5.4 auto-backport-to-UE5.3 Auto backport to UE 5.3 auto-backport-to-UE5.2 Auto backport to UE 5.2 auto-backport-to-UE5.5 labels Jul 16, 2024
@mcottontensor mcottontensor merged commit 0869189 into EpicGamesExt:master Jul 17, 2024
@mcottontensor mcottontensor deleted the disconnect_flow branch July 17, 2024 01:18
@github-actions
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
UE5.4 Backport failed because of merge conflicts
UE5.3 Backport failed because of merge conflicts
UE5.2 Backport failed because of merge conflicts
UE5.5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 197

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.2 Auto backport to UE 5.2 auto-backport-to-UE5.3 Auto backport to UE 5.3 auto-backport-to-UE5.4 Auto backport to UE 5.4 auto-backport-to-UE5.5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Disconnect overlay incorrectly showing error overlay

2 participants