Skip to content

Conversation

@lukehb
Copy link
Contributor

@lukehb lukehb commented Nov 20, 2025

Relevant components:

  • Signalling server
  • Frontend library

Problem statement:

It is useful to be able to use the player id as a unique identifier that is common between UE side stats and frontend side stats; however, the player id is not actually exposed to TS/JS because the SS strips it out of signalling messages.

Solution

  • Make SS not strip the player id
  • Expose the playerId as a field that is accessible

Test Plan and Compatibility

I ran this locally and was able to access the playerId using the window.pixelStreaming using my developer console in Chrome.

@lukehb lukehb added auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.7 labels Nov 20, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: 8986621

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@Belchy06 Belchy06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukehb lukehb merged commit 6733632 into master Nov 24, 2025
9 of 10 checks passed
@lukehb lukehb deleted the playerid branch November 24, 2025 06:03
github-actions bot pushed a commit that referenced this pull request Nov 24, 2025
(cherry picked from commit 6733632)
@github-actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
UE5.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

lukehb added a commit that referenced this pull request Nov 24, 2025
* Exposed playerid (#728)

(cherry picked from commit 6733632)

* Expose player id and improve signalling library

Add ability to access player id on the frontend and remove player id stripping from the signalling library. This change backports the 'Exposed playerid' feature.

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
mcottontensor added a commit that referenced this pull request Dec 8, 2025
* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711)

(cherry picked from commit 7790838)

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#712)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update signalling library readme, patch bump

* Update readme for ui library, bump patch version

* Update frontend docs, patch bump

* Update common readme, patch bump

* Update RELEASE_VERSION

0.1.1

* Update 5.7 with docs and housekeeping changes (#718)

* Bump markdown link checker version for security patch

#691

* Update link checker to permit 429 code from Github as valid

* Update user-agent in link checker action to try prevent 403 forbidden on some sites

* Update link checker to accept HTTP status 403 (forbidden)

* Remove broken link about eslint

* Modify README for mediasoup-sdp-bridge to remove broken link

Updated README to reflect fork status and removed badges.

* Update workflow triggers for markdown files in push and PR

* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709)

* Bring 5.7 changes to master branch (docs + sdpMid fix) (#716)

* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711)

(cherry picked from commit 7790838)

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#712)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update signalling library readme, patch bump

* Update readme for ui library, bump patch version

* Update frontend docs, patch bump

* Update common readme, patch bump

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update copyright notice

* Update copyright notice in CONTRIBUTING.md

* Update copyright notice

* Update copyright in frontend/readme.md

* Delete .changeset/light-games-wonder.md

---------

Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Cut new GH release for 5.7 - 0.1.2

* [UE5.7] Exposed playerid (#728) (#729)

* Exposed playerid (#728)

(cherry picked from commit 6733632)

* Expose player id and improve signalling library

Add ability to access player id on the frontend and remove player id stripping from the signalling library. This change backports the 'Exposed playerid' feature.

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#730)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [UE5.7] Make this.peerConnection.getStats() access safe (#719) (#731)

* Update PeerConnectionController.ts (#719)

Fix for throwing error when peerConnection is not defined

(cherry picked from commit 9a5cd8e)

* Create polite-knives-hang.md

---------

Co-authored-by: fabian-rehm <fabian.rehm@porter.de>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* [UE5.7] SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734) (#737)

* SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734)

* fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe

fixes: #722

* Update Frontend/library/src/WebXR/WebXRController.ts

* Update Frontend/library/src/WebXR/WebXRController.ts

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
(cherry picked from commit cc8c923)

* Fix iframe streaming issue due to SecurityError

---------

Co-authored-by: Leon Radley <leon@radley.se>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#732)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Updating npm publish for new npmjs trusted publisher stuff. (#744)

* Trying to figure out OIDC

* Trying to debug OIDC issues.

* Duplicating id-token

* Still debugging OIDC issues. Adding debugging steps.

* Debugging OIDC.

* Fix OIDC (#745)

* Updating npm to allow oidc auth

* bumping common patch version to test publish.

* Fixing up package info.

* Fix link descriptions for UE 5.7 (#743) (#747)

(cherry picked from commit ff2b1bf)

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
Co-authored-by: fabian-rehm <fabian.rehm@porter.de>
Co-authored-by: Leon Radley <leon@radley.se>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
mcottontensor added a commit that referenced this pull request Dec 8, 2025
* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711)

(cherry picked from commit 7790838)

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#712)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update signalling library readme, patch bump

* Update readme for ui library, bump patch version

* Update frontend docs, patch bump

* Update common readme, patch bump

* Update RELEASE_VERSION

0.1.1

* Update 5.7 with docs and housekeeping changes (#718)

* Bump markdown link checker version for security patch

#691

* Update link checker to permit 429 code from Github as valid

* Update user-agent in link checker action to try prevent 403 forbidden on some sites

* Update link checker to accept HTTP status 403 (forbidden)

* Remove broken link about eslint

* Modify README for mediasoup-sdp-bridge to remove broken link

Updated README to reflect fork status and removed badges.

* Update workflow triggers for markdown files in push and PR

* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709)

* Bring 5.7 changes to master branch (docs + sdpMid fix) (#716)

* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711)

(cherry picked from commit 7790838)

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#712)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update signalling library readme, patch bump

* Update readme for ui library, bump patch version

* Update frontend docs, patch bump

* Update common readme, patch bump

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update copyright notice

* Update copyright notice in CONTRIBUTING.md

* Update copyright notice

* Update copyright in frontend/readme.md

* Delete .changeset/light-games-wonder.md

---------

Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Cut new GH release for 5.7 - 0.1.2

* [UE5.7] Exposed playerid (#728) (#729)

* Exposed playerid (#728)

(cherry picked from commit 6733632)

* Expose player id and improve signalling library

Add ability to access player id on the frontend and remove player id stripping from the signalling library. This change backports the 'Exposed playerid' feature.

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#730)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [UE5.7] Make this.peerConnection.getStats() access safe (#719) (#731)

* Update PeerConnectionController.ts (#719)

Fix for throwing error when peerConnection is not defined

(cherry picked from commit 9a5cd8e)

* Create polite-knives-hang.md

---------

Co-authored-by: fabian-rehm <fabian.rehm@porter.de>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* [UE5.7] SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734) (#737)

* SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734)

* fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe

fixes: #722

* Update Frontend/library/src/WebXR/WebXRController.ts

* Update Frontend/library/src/WebXR/WebXRController.ts

---------

Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
(cherry picked from commit cc8c923)

* Fix iframe streaming issue due to SecurityError

---------

Co-authored-by: Leon Radley <leon@radley.se>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>

* Updated NPM changelogs (#732)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Updating npm publish for new npmjs trusted publisher stuff. (#744)

* Trying to figure out OIDC

* Trying to debug OIDC issues.

* Duplicating id-token

* Still debugging OIDC issues. Adding debugging steps.

* Debugging OIDC.

* Fix OIDC (#745)

* Updating npm to allow oidc auth

* bumping common patch version to test publish.

* Fixing up package info.

* Fix link descriptions for UE 5.7 (#743) (#747)

(cherry picked from commit ff2b1bf)

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

* Updated NPM changelogs (#749)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fixing repo url.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
Co-authored-by: fabian-rehm <fabian.rehm@porter.de>
Co-authored-by: Leon Radley <leon@radley.se>
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.7

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants