-
Notifications
You must be signed in to change notification settings - Fork 178
Expose playerid for programmatic access #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Belchy06
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 6733632)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
* Exposed playerid (#728) (cherry picked from commit 6733632) * Expose player id and improve signalling library Add ability to access player id on the frontend and remove player id stripping from the signalling library. This change backports the 'Exposed playerid' feature. --------- Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com>
* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711) (cherry picked from commit 7790838) Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#712) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update signalling library readme, patch bump * Update readme for ui library, bump patch version * Update frontend docs, patch bump * Update common readme, patch bump * Update RELEASE_VERSION 0.1.1 * Update 5.7 with docs and housekeeping changes (#718) * Bump markdown link checker version for security patch #691 * Update link checker to permit 429 code from Github as valid * Update user-agent in link checker action to try prevent 403 forbidden on some sites * Update link checker to accept HTTP status 403 (forbidden) * Remove broken link about eslint * Modify README for mediasoup-sdp-bridge to remove broken link Updated README to reflect fork status and removed badges. * Update workflow triggers for markdown files in push and PR * Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) * Bring 5.7 changes to master branch (docs + sdpMid fix) (#716) * Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711) (cherry picked from commit 7790838) Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#712) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update signalling library readme, patch bump * Update readme for ui library, bump patch version * Update frontend docs, patch bump * Update common readme, patch bump --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update copyright notice * Update copyright notice in CONTRIBUTING.md * Update copyright notice * Update copyright in frontend/readme.md * Delete .changeset/light-games-wonder.md --------- Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Cut new GH release for 5.7 - 0.1.2 * [UE5.7] Exposed playerid (#728) (#729) * Exposed playerid (#728) (cherry picked from commit 6733632) * Expose player id and improve signalling library Add ability to access player id on the frontend and remove player id stripping from the signalling library. This change backports the 'Exposed playerid' feature. --------- Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#730) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [UE5.7] Make this.peerConnection.getStats() access safe (#719) (#731) * Update PeerConnectionController.ts (#719) Fix for throwing error when peerConnection is not defined (cherry picked from commit 9a5cd8e) * Create polite-knives-hang.md --------- Co-authored-by: fabian-rehm <fabian.rehm@porter.de> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * [UE5.7] SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734) (#737) * SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734) * fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe fixes: #722 * Update Frontend/library/src/WebXR/WebXRController.ts * Update Frontend/library/src/WebXR/WebXRController.ts --------- Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> (cherry picked from commit cc8c923) * Fix iframe streaming issue due to SecurityError --------- Co-authored-by: Leon Radley <leon@radley.se> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#732) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Updating npm publish for new npmjs trusted publisher stuff. (#744) * Trying to figure out OIDC * Trying to debug OIDC issues. * Duplicating id-token * Still debugging OIDC issues. Adding debugging steps. * Debugging OIDC. * Fix OIDC (#745) * Updating npm to allow oidc auth * bumping common patch version to test publish. * Fixing up package info. * Fix link descriptions for UE 5.7 (#743) (#747) (cherry picked from commit ff2b1bf) Co-authored-by: Flo Edelmann <git@flo-edelmann.de> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> Co-authored-by: fabian-rehm <fabian.rehm@porter.de> Co-authored-by: Leon Radley <leon@radley.se> Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
* Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711) (cherry picked from commit 7790838) Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#712) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update signalling library readme, patch bump * Update readme for ui library, bump patch version * Update frontend docs, patch bump * Update common readme, patch bump * Update RELEASE_VERSION 0.1.1 * Update 5.7 with docs and housekeeping changes (#718) * Bump markdown link checker version for security patch #691 * Update link checker to permit 429 code from Github as valid * Update user-agent in link checker action to try prevent 403 forbidden on some sites * Update link checker to accept HTTP status 403 (forbidden) * Remove broken link about eslint * Modify README for mediasoup-sdp-bridge to remove broken link Updated README to reflect fork status and removed badges. * Update workflow triggers for markdown files in push and PR * Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) * Bring 5.7 changes to master branch (docs + sdpMid fix) (#716) * Fix: Firefox connectivity issues when sdpMLineIndex and sdpMid are stripped. (#709) (#711) (cherry picked from commit 7790838) Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#712) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update signalling library readme, patch bump * Update readme for ui library, bump patch version * Update frontend docs, patch bump * Update common readme, patch bump --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update copyright notice * Update copyright notice in CONTRIBUTING.md * Update copyright notice * Update copyright in frontend/readme.md * Delete .changeset/light-games-wonder.md --------- Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Cut new GH release for 5.7 - 0.1.2 * [UE5.7] Exposed playerid (#728) (#729) * Exposed playerid (#728) (cherry picked from commit 6733632) * Expose player id and improve signalling library Add ability to access player id on the frontend and remove player id stripping from the signalling library. This change backports the 'Exposed playerid' feature. --------- Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#730) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [UE5.7] Make this.peerConnection.getStats() access safe (#719) (#731) * Update PeerConnectionController.ts (#719) Fix for throwing error when peerConnection is not defined (cherry picked from commit 9a5cd8e) * Create polite-knives-hang.md --------- Co-authored-by: fabian-rehm <fabian.rehm@porter.de> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * [UE5.7] SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734) (#737) * SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe (#734) * fix: SecurityError: Failed to execute 'isSessionSupported' on 'XRSystem' when in iframe fixes: #722 * Update Frontend/library/src/WebXR/WebXRController.ts * Update Frontend/library/src/WebXR/WebXRController.ts --------- Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> (cherry picked from commit cc8c923) * Fix iframe streaming issue due to SecurityError --------- Co-authored-by: Leon Radley <leon@radley.se> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> * Updated NPM changelogs (#732) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Updating npm publish for new npmjs trusted publisher stuff. (#744) * Trying to figure out OIDC * Trying to debug OIDC issues. * Duplicating id-token * Still debugging OIDC issues. Adding debugging steps. * Debugging OIDC. * Fix OIDC (#745) * Updating npm to allow oidc auth * bumping common patch version to test publish. * Fixing up package info. * Fix link descriptions for UE 5.7 (#743) (#747) (cherry picked from commit ff2b1bf) Co-authored-by: Flo Edelmann <git@flo-edelmann.de> * Updated NPM changelogs (#749) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fixing repo url. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Luke Bermingham <1215582+lukehb@users.noreply.github.com> Co-authored-by: fabian-rehm <fabian.rehm@porter.de> Co-authored-by: Leon Radley <leon@radley.se> Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Relevant components:
Problem statement:
It is useful to be able to use the player id as a unique identifier that is common between UE side stats and frontend side stats; however, the player id is not actually exposed to TS/JS because the SS strips it out of signalling messages.
Solution
playerIdas a field that is accessibleTest Plan and Compatibility
I ran this locally and was able to access the
playerIdusing thewindow.pixelStreamingusing my developer console in Chrome.