Skip to content

fixing public ip stomping in windows batch script.#780

Merged
mcottontensor merged 1 commit intoEpicGamesExt:masterfrom
mcottontensor:public_ip_fix
Feb 3, 2026
Merged

fixing public ip stomping in windows batch script.#780
mcottontensor merged 1 commit intoEpicGamesExt:masterfrom
mcottontensor:public_ip_fix

Conversation

@mcottontensor
Copy link
Collaborator

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

When supplying --publicip on the windows batch scripts it was getting overridden.

Solution

The SetPublicIP step now checks that no ip has been previously specified.

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2026

⚠️ No Changeset found

Latest commit: 7bcadbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcottontensor
Copy link
Collaborator Author

fixes #768

@mcottontensor mcottontensor added auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.5 auto-backport-to-UE5.6 auto-backport-to-UE5.7 labels Feb 3, 2026
@mcottontensor mcottontensor merged commit f288581 into EpicGamesExt:master Feb 3, 2026
12 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 3, 2026
github-actions bot pushed a commit that referenced this pull request Feb 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

💔 Some backports could not be created

Status Branch Result
UE5.5 Backport failed because of merge conflicts
UE5.6
UE5.7

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 780

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@mcottontensor mcottontensor deleted the public_ip_fix branch February 3, 2026 00:22
mcottontensor added a commit that referenced this pull request Feb 3, 2026
(cherry picked from commit f288581)

Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com>
mcottontensor added a commit that referenced this pull request Feb 3, 2026
(cherry picked from commit f288581)

Co-authored-by: mcottontensor <80377552+mcottontensor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.5 auto-backport-to-UE5.6 auto-backport-to-UE5.7

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant