[UE5.6] Viewport resolution scale parameter 2 (#759)#809
Merged
mcottontensor merged 2 commits intoEpicGamesExt:UE5.6from Apr 23, 2026
Merged
[UE5.6] Viewport resolution scale parameter 2 (#759)#809mcottontensor merged 2 commits intoEpicGamesExt:UE5.6from
mcottontensor merged 2 commits intoEpicGamesExt:UE5.6from
Conversation
* Add ViewportResolutionScale configuration parameter
* Add Docs for Viewport Resolution Scale in Frontend/Docs/Settings Panel.md
* Address PR feedback: improve ViewportResolutionScale configuration
* Harden ViewportResScale: round output, warn past encoder limit, rename constant
- Round scaled dimensions to integers before sending Resolution.Width /
Height commands to UE (non-integers were being JSON-stringified and
handed to cvar parsing).
- Warn via Logger when a scaled dimension exceeds the H.264 4096 limit so
large viewports with high scales surface a clear encoding-failure hint.
- Rename NumericParameters.ViewportResolutionScale -> ViewportResScale so
the TS constant matches the URL-param / persisted key ('ViewportResScale').
- Add Config.hasNumericSetting and fall back to 1.0 in VideoPlayer when
the setting is absent, so custom Config subclasses do not throw on
every resize.
- Add VideoPlayer Jest coverage for default, scaled, rounded, >4096-warn,
within-limit, missing-setting-fallback, and flag-disabled paths.
---------
Co-authored-by: Matthew.Cotton <matt@tensorworks.com.au>
(cherry picked from commit 60da95c)
# Conflicts:
# Frontend/library/src/VideoPlayer/VideoPlayer.ts
🦋 Changeset detectedLatest commit: 35e815e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertoUE5.6:Questions ?
Please refer to the Backport tool documentation