Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the logic for enabling the TopHolders module and improves compatibility for nodes that enable the module after initial setup. It removes the distinction between fresh and existing nodes, ensuring the store key is always added when TopHolders is enabled, and updates the upgrade handler to automatically add the store if needed. Additionally, it fixes a timestamp issue in the TopHolders cache.
TopHolders module improvements:
storeKeyswhen TopHolders is enabled, making the initialization consistent and easier to maintain (evmd/app.go).evmd/app.go).Upgrade handling enhancements:
evmd/upgrades.go).Bug fix:
sdkCtxinstead of the current system time, ensuring accurate and deterministic timestamps (x/topholders/keeper/cache.go).Cleanup:
filepathimport fromevmd/app.go, reflecting the simplified initialization logic.