fix: set cache timestamp only when changes are made #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typotter
requested review from
iamnirav and
sameerank
and removed request for
iamnirav
typotter
commented
Apr 7, 2025
typotter
commented
Apr 7, 2025
typotter
commented
Apr 7, 2025
sameerank
approved these changes
Apr 7, 2025
sameerank
left a comment
sameerank
left a comment
There was a problem hiding this comment.
Questions to help me understand, but lgtm otherwise
typotter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Fixes FF-4278 and FF-3947
Motivation and Context
Updating the cache timestamp when it hasn't change causes issues when invalidating the cache based solely on time (and not on the eTag).
While we're here, we want to default the SDKs to squash exceptions during initialization
Description
How has this been documented?
linear
How has this been tested?