-
Notifications
You must be signed in to change notification settings - Fork 3
fix: Store configuration atomically #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
approved these changes
Apr 11, 2025
Contributor
aarsilv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work rewiring all this! Much cleaner and easier to understand. And now we know the configuration will be atomically in sync too 📈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Fixes FF-4302
Motivation and Context
The PHP SDK stores flag, bandit, bandit reference and config metadata in separate entries in the cache. This design: the reliance on metadata to determine whether to repopulate the cached config entries is susceptible to the volatile nature of the cache. Entries are evicted and go unfound when assignments are attempted until the cache expires.
Description
ConfigurationWireformat. Added classes define theConfigurationWireformat and its sub-types.Configurationobject - holds the flags, bandits, references and metadataConfigurationStore- refactored to hold the current, active configuration and load configuration from the persistent cache when neededUFCParserand moved the logic toFlagConfigurationLoaderdeals just with checking the expiration of the cache and handing theeTagoff to the Http client.reloadIfExpiredremoved from assignment calls. PHP processes are short lived. The process starts up, theEppoClientis initialized, a response is computed and sent to the client, then the process dies. Configuration is loaded from the cache on each init, and if expired, the config is fetched from the APIEppoClientto pull the current config object once for each assignment operation and use it through the operation.How has this been documented?
External API is unchanged. Behaviour is fixed.
How has this been tested?