Merged
Conversation
sameerank
approved these changes
Jan 29, 2025
| { | ||
| "name": "@eppo/react-native-sdk", | ||
| "version": "3.5.1", | ||
| "version": "3.5.2", |
Contributor
There was a problem hiding this comment.
Thoughts on doing 3.4.1 so we're not skipping a minor version? I'm also fine with this
Collaborator
Author
There was a problem hiding this comment.
We would need to apply this fix in a branch from 3.4.0 to avoid shipping the minor change brought by 3.5 along with it.
I think it's not uncommon to skip minor versions - we have done so in the past when we've merged new features so quickly they get merged into a single release
Contributor
There was a problem hiding this comment.
Sounds good. Yep let's proceed with the skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We recently upgrade from
npm-publishv1 to v3. See #68In the intervening versions,
ignore-scriptswas introduced, meaning ouryarn prepackscript was not getting run as part of the npm-publish command.Because of this, we shipped 3 broken releases (v3.4.0, v3.5.0 and v3.5.1) without a
lib/folder.Changes
-explicitly run
yarn prepackin the publish workflow