Skip to content

🐛 Do not fail process if Wikidata item doesn't exist#76

Merged
jbelien merged 2 commits intomasterfrom
fix/fail-on-404
Mar 16, 2026
Merged

🐛 Do not fail process if Wikidata item doesn't exist#76
jbelien merged 2 commits intomasterfrom
fix/fail-on-404

Conversation

@jbelien
Copy link
Member

@jbelien jbelien commented Mar 16, 2026

No description provided.

@jbelien jbelien self-assigned this Mar 16, 2026
@jbelien jbelien added the bug Something isn't working label Mar 16, 2026
@jbelien jbelien requested a review from Copilot March 16, 2026 21:19
@jbelien jbelien merged commit 2cefe05 into master Mar 16, 2026
8 of 9 checks passed
@jbelien jbelien deleted the fix/fail-on-404 branch March 16, 2026 21:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a guard to skip further processing of a Wikidata item when the downloaded file doesn't exist or isn't readable, preventing the process from crashing when a Wikidata item can't be fetched (e.g., 404 response).

Changes:

  • Added a file existence and readability check after self::save() to gracefully continue the loop instead of failing on a missing file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

2 participants