Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
The code and content of this Pull Request has been generated by @copilot.
This pull request introduces significant improvements to the Wikidata fetching logic in
WikidataCommand.php, focusing on better handling of rate limits, retries, and error scenarios. The changes ensure more robust and respectful interaction with the Wikidata API, helping to avoid rate-limiting issues and partial downloads.Enhancements to request handling and robustness:
throttleRequestsmethod and related constants (REQUEST_INTERVAL_MICROSECONDS). [1] [2]Retry-Afterheader when available, and setting a default retry delay (MAX_RETRIES,DEFAULT_RETRY_DELAY_MILLISECONDS, andretryDelayMilliseconds). [1] [2] [3]Error handling and cleanup:
savemethod to indicate success or failure. [1] [2] [3]GuzzleExceptionerrors, ensuring all error cases are covered and partial files are removed appropriately.Other improvements:
savemethod signature and its usage to return a boolean, improving clarity and reliability of file existence checks after download attempts. [1] [2]These changes collectively make the Wikidata fetching process more reliable, respectful of API limits, and easier to maintain.