Skip to content

Conversation

@gyorb
Copy link
Contributor

@gyorb gyorb commented Nov 23, 2018

resolves #125

@gyorb gyorb requested a review from vodorok November 23, 2018 10:11
@gyorb
Copy link
Contributor Author

gyorb commented Nov 23, 2018

@vodorok did we require build.log and bin directory in the gitignore file?

@vodorok
Copy link
Collaborator

vodorok commented Nov 23, 2018

I had a bin directory under ./eclipse-plugin/eclipse/cc.codechecker.eclipse.plugin. I think this folder is created by eclipse plugin m2e. By my understanding, this plugin is needed for building the plugin through eclipse. During the uplift development, I've needed to update the maven project multiple times with m2e, and this could created this bin directory. Please take a look on this related StackOverflow Answer. When I deleted the folder, and built the plugin, the folder wouldn't reappear, nor when checked out freshly and built on terminal. The build went fine, so I don't think this line is needed in the gitignores.
For the build.log: In my uplift work dir, I didn`t found this file generated.

@vodorok vodorok merged commit 7fa3007 into Ericsson:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create one top level .gitignore

2 participants