Conversation
Discookie
left a comment
Discookie
left a comment
There was a problem hiding this comment.
There's a couple things, but otherwise looking good!
The biggest problem is that once the highlights are shown, it's impossible to hide the highlights.
The highlights only go away when there's a file switch.
csordasmarton
force-pushed
the
highlight_bug_path_positions
branch
from
c7e638d to
51a4d0f
Compare
|
@Discookie Good catch. I think I fixed all the problems you mentioned. |
|
|
||
| // Decoration type for highlighting report step positions. | ||
| const reportStepDecorationType = window.createTextEditorDecorationType({ | ||
| backgroundColor: new ThemeColor('editorMarkerNavigationWarning.background') |
There was a problem hiding this comment.
Really not sure about this color choice...
Played around with a couple other themes, about 50% of them look like this, both light and dark.
I think it would be better to have our own contributed color here.
There was a problem hiding this comment.
@Discookie I added new configurable colors and updated the screenshots in this PR message above.
There was a problem hiding this comment.
Yep, that works now for most themes, thanks!
csordasmarton
force-pushed
the
highlight_bug_path_positions
branch
from
51a4d0f to
bfcb203
Compare
2 participants
Screenshots:
