Skip to content

Added new configuration parameters#10

Merged
Phil-Friderici merged 1 commit into
Ericsson:masterfrom
albgus:transport_maps
Jun 10, 2015
Merged

Added new configuration parameters#10
Phil-Friderici merged 1 commit into
Ericsson:masterfrom
albgus:transport_maps

Conversation

@albgus
Copy link
Copy Markdown
Contributor

@albgus albgus commented Jan 23, 2015

Ability to configure transport maps with the parameters main_transport_maps, transport_maps and transport_maps_external.

Added the virtual_aliases_external and transport_maps_external to allow alternative sources (e.g. ldap_table(5)), without having to provide information to virtual_aliases or transport_aliases. Earlier the main_virtual_alias_maps parameter would only be written to main.cf if virtual_aliases was defined.

Added virtual_alias_domains parameter to control the corresponding variable in main.cf.

Comment thread templates/main.cf.erb Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this

@Phil-Friderici
Copy link
Copy Markdown
Contributor

do you mind rebasing this into one commit ?

@Phil-Friderici
Copy link
Copy Markdown
Contributor

Please don't use type() anymore. It will get deprecated with Puppet v4.
Please add spec tests for all added functionality and also for invalid values.

@albgus
Copy link
Copy Markdown
Contributor Author

albgus commented Jun 9, 2015

I think I got most of the points now. If it looks good I can squash all of the commits together for a merge.

Comment thread spec/classes/init_spec.rb Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use
it { should contain_file('postfix_main.cf').without_content(/^transport_maps/) }
instead

* main_transport_maps Specify a custom transport map file not managed by
  this module.

* transport_maps Allow direct delivery for specified domains.

* transport_maps_external Do not manage the transport maps.

* virtual_alias_domains Limit which addresses to do virtual alias lookups for.

* virtual_aliases_external Do not manage the virtual aliases.
@Phil-Friderici Phil-Friderici merged commit 666e0a4 into Ericsson:master Jun 10, 2015
@Phil-Friderici
Copy link
Copy Markdown
Contributor

released in v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants