Add parameters#28
Merged
Merged
Conversation
| if is_integer($main_mailbox_size_limit_real) == false { fail("main_mailbox_size_limit must be an integer and is set to <${main_mailbox_size_limit_real}>") } | ||
| if $main_mailbox_size_limit_real + 0 < 0 { fail("main_mailbox_size_limit needs a minimum value of 0 and is set to <${main_mailbox_size_limit_real}>") } | ||
| validate_string($main_mydestination_real) | ||
| if $main_mydomain != undef { if is_domain_name($main_mydomain) != true { fail("main_mydomain must be a domain name and is set to <${main_mydomain}>") } } |
Contributor
There was a problem hiding this comment.
think using an and between both conditions would ease the readability
Contributor
|
Thanks @anders-larsson ! All there, looks good to me. Please have a look at my comment regarding the validation. |
Contributor
Author
|
Cool. I'm not working tomorrow. Will fix on Monday. Thanks for fast review! |
Contributor
|
@anders-larsson no worries, neither I am working ;) |
anders-larsson
force-pushed
the
add_parameters
branch
from
22d194f to
f13a39e
Compare
Contributor
Author
|
I've updated the first commit to include your requested changes. |
| } | ||
| end | ||
|
|
||
| describe "with main_smtpd_helo_required set to 'yes' and main_smtpd_restrictions" do |
Contributor
There was a problem hiding this comment.
I see no mandatory connection of $main_smtpd_helo_required and $main_smtpd_restrictions in the code.
Please change the tests to become individual for each parameter too.
anders-larsson
force-pushed
the
add_parameters
branch
from
f13a39e to
f633feb
Compare
Contributor
Author
|
Updated! :) |
Contributor
|
Thanks @anders-larsson ! Released in v1.4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a total of four new parameters to configure my_domain, smtpd_helo_required, smtpd_helo_restrictions and finally smtpd_recipient_restrictions.
With the default settings no additional entries are added to main.cf.