Convert to PDK and Puppet 7

[Phil-Friderici]

This collection of commits does convert the module to Puppet 7 and PDK compatibility. It satisfies puppet-lint and robucops.

I would like to get this PR reviewed and merged before continueing to work on the module and unit tests.

[anders-larsson]

Looks very good. Only thing I can find is the FIXME entry in header which should probably be fixed.

Love the simplification allowed by using modul hiera.

[Phil-Friderici]

Thanks for your review, I guess now this PR is complete :)

[anders-larsson]

BTW. Would it make more sense to add the "current" default to say Ubuntu.yaml in Hiera and then in cases where it is something different it would be added to a Ubuntu-14.04 YAML file? This would make the module automatically support new releases (unless they're different)?

Or do you think it is better to be explicit?

So in the case of Ubuntu it would be:
Ubuntu.yaml

postfix::main_daemon_directory: '/usr/lib/postfix/sbin'

Ubuntu-14.04.yaml

 postfix::main_daemon_directory: '/usr/lib/postfix' 

[Phil-Friderici]

That's a good question, I am not sure myself what I would prefer. I like to be explicit because it eleminates guessworking. On the other side it brings the 'cost' of adding support for new versions later on.

In the SSH module (v4 branch) I have created explicit configuration files for each OS family and variation. I have to confess that I like it a lot. All settings for an specific OS are collected in hiera files :)

But please let us continue that question outside of this PR that is dedicated to migrate to Puppet 7. I would like to create new PRs for refactoring the unit tests to start using rspec-puppet-facts and anothers for refactoring details like the above.

[anders-larsson]

Sure. Let's get this merged!