Skip to content

Use EPP templates#65

Merged
Phil-Friderici merged 2 commits into
Ericsson:masterfrom
Phil-Friderici:convert_templates
May 15, 2023
Merged

Use EPP templates#65
Phil-Friderici merged 2 commits into
Ericsson:masterfrom
Phil-Friderici:convert_templates

Conversation

@Phil-Friderici
Copy link
Copy Markdown
Contributor

No description provided.

@anders-larsson
Copy link
Copy Markdown
Contributor

We shouldn't fully utilise the epp functionality and use parameters for the template? Will of course be a lot of extra parameters thoiugh.

@Phil-Friderici
Copy link
Copy Markdown
Contributor Author

Added parameters to the EPP and manifest. Had issues with Array($main_mynetworks, true) after adding the parameters to the template. Looked like the array wasn't really empty, after changing to any2array it worked well again :)

Just a though:
Maybe we should drop support for strings when actually an array should be used ?
That would be: main_mynetworks & main_inet_interfaces.
When releasing a new major version we can destroy backward compatibility ;)

@anders-larsson
Copy link
Copy Markdown
Contributor

Maybe we should drop support for strings when actually an array should be used ?
That would be: main_mynetworks & main_inet_interfaces.

I agree with this. Might as well.

@Phil-Friderici
Copy link
Copy Markdown
Contributor Author

Changed the mentioned parameters to be array only. Will use a new major version once release.
Next week I will check which Postfix parameters to add natively to the module.
After that we can finally add more OS families ;)

@Phil-Friderici Phil-Friderici merged commit 98a4fae into Ericsson:master May 15, 2023
@Phil-Friderici Phil-Friderici deleted the convert_templates branch May 15, 2023 11:49
@anders-larsson
Copy link
Copy Markdown
Contributor

anders-larsson commented May 15, 2023

Great. I'll go through the OSs currently not added and add configuration for them.

Forgot, we still you still wanted to add new parameters for the most common options. Is this still kthe case?

@Phil-Friderici
Copy link
Copy Markdown
Contributor Author

Yes, I am adding new params in at the moment and will create a new PR for these. So better wait a little bit before adding new OSs ;)

Let's discuss which new params should get added over there...

@Phil-Friderici
Copy link
Copy Markdown
Contributor Author

The new PR is here: #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants