Conversation
Collaborator
This change is important, to support generated source files. Generated source files despite their extension being .c, .cc or .cpp were filtered because they aren't considered source files.
furtib
force-pushed
the
support_genrule
branch
from
8f577d3 to
7b2d1bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added generated files to the CompileInfo aspect.
Why:
We want to support analysis on generated files, so that they can be used during CTU analysis
What:
Removed is_source validation for source files.
Generated files are regarded as output, not input, and thus they aren't regarded as source files and were filtered from the list of source files.
Addresses:
#99
Depends on: #101