Merged
Conversation
furtib
added
enhancement
furtib
force-pushed
the
rebase-config-file-handling
branch
from
af331f3 to
ff95f96
Compare
furtib
force-pushed
the
rebase-config-file-handling
branch
from
ccccf5f to
8757a1a
Compare
furtib
commented
Nov 27, 2025
Szelethus
reviewed
Dec 1, 2025
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
You'll need to adjust the summary.
Szelethus
approved these changes
Dec 1, 2025
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Please add a comment where I placed the nit. Otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want to handle configurations for both the monolithic and
per_filerule.I want to use the same implementation for both, and don't want to either repeat code or have cyclic includes.
What:
I have created a file
codechecker_config.bzlin which everything related to the rule codechecker_config lives.I have included this rule in
codechecker.bzland used it.Addresses:
(In the long run: #30 )