Skip to content

Use python toolchain instead of python runtime#146

Merged
Szelethus merged 1 commit intoEricsson:mainfrom
nettle:python-toolchain
Jan 27, 2026
Merged

Use python toolchain instead of python runtime#146
Szelethus merged 1 commit intoEricsson:mainfrom
nettle:python-toolchain

Conversation

@nettle
Copy link
Copy Markdown
Collaborator

@nettle nettle commented Jan 16, 2026

Why:
Need to make python runtime more portable
and be ready for rules_python support.

What:

  • Add toolchain for python instead of _python_runtime
  • Add portable functions for python
  • Fix register_toolchains

Addresses:
First step for rules_python support (Bazel 8) #108

Copy link
Copy Markdown
Contributor

@furtib furtib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch looks great!
The testing breaks only because the WORKSPACE changed!
This change should also be represented in README.md.

Comment thread WORKSPACE
Why:
Need to make python runtime more portable
and be ready for rules_python support.

What:
- Add toolchain for python instead of _python_runtime
- Add portable functions for python
- Fix register_toolchains
- Add to FOSS template
@nettle nettle requested a review from furtib January 24, 2026 16:51
Copy link
Copy Markdown
Contributor

@furtib furtib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@furtib furtib requested a review from Szelethus January 26, 2026 15:55
@nettle
Copy link
Copy Markdown
Collaborator Author

nettle commented Jan 26, 2026

Hi @Szelethus,
If you dont mind I would suggest merging this to move forward with Bazel 8 support

Copy link
Copy Markdown
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is totally NFC, right? If so, lets land it! LGTM!

@Szelethus Szelethus merged commit 900730e into Ericsson:main Jan 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants