Skip to content

Add debugging for failing commands#168

Merged
Szelethus merged 4 commits intoEricsson:mainfrom
furtib:log-failed-commands
Jan 27, 2026
Merged

Add debugging for failing commands#168
Szelethus merged 4 commits intoEricsson:mainfrom
furtib:log-failed-commands

Conversation

@furtib
Copy link
Copy Markdown
Contributor

@furtib furtib commented Jan 26, 2026

Why:
We currently have no or very limited debugging possibilities when running unit tests.
We should log the output of failing Bazel commands.

What:

  • Added logging to base class, for non 0 returncode commands.

Addresses:
Fixes: #147
Fixes: #150

@furtib furtib requested a review from Szelethus January 26, 2026 15:39
@furtib furtib self-assigned this Jan 26, 2026
@furtib furtib added the test ☑️ Adding or refactoring tests label Jan 26, 2026
@furtib furtib force-pushed the log-failed-commands branch from 0745d95 to 9d2e75e Compare January 26, 2026 15:50
Copy link
Copy Markdown
Collaborator

@nettle nettle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question

Comment thread test/common/base.py
Comment thread test/common/base.py Outdated
Copy link
Copy Markdown
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@Szelethus Szelethus merged commit c07f18a into Ericsson:main Jan 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test ☑️ Adding or refactoring tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use universal_newlines in subprocess Print out stdout and stderr when test executed with -vvv

3 participants