Format with buildifier on all files#183
Merged
furtib merged 3 commits intoEricsson:mainfrom Feb 4, 2026
Merged
Conversation
furtib
added
the
non-functional change ☮️
furtib
force-pushed
the
fix-buildifier-test
branch
from
f4c44d0 to
d4c907c
Compare
Szelethus
reviewed
Feb 3, 2026
Contributor
Szelethus
left a comment
Szelethus
left a comment
There was a problem hiding this comment.
Can we do a sanity check on whether we configured buildifier and and pylint the same? (spacing, indentation, etc).
Otherwise LGTM.
Contributor
Author
|
Buildifier does not have a configuration option. |
Szelethus
approved these changes
Feb 3, 2026
furtib
changed the title
furtib
force-pushed
the
fix-buildifier-test
branch
from
79a2dd5 to
5c5f5ad
Compare
furtib
added a commit
to furtib/codechecker_bazel
that referenced
this pull request
Feb 4, 2026
Why: We want the buildifier CI job to pass What: - Ran `buildifier -r .` to format all `.bzl` and `BUILD` files. Addresses:
furtib
added a commit
to furtib/codechecker_bazel
that referenced
this pull request
Feb 4, 2026
Why: We want the buildifier CI job to pass What: - Ran `buildifier -r .` to format all `.bzl` and `BUILD` files. Addresses:
furtib
added a commit
to furtib/codechecker_bazel
that referenced
this pull request
Feb 4, 2026
Why: We want the buildifier CI job to pass What: - Ran `buildifier -r .` to format all `.bzl` and `BUILD` files. Addresses:
furtib
added a commit
to furtib/codechecker_bazel
that referenced
this pull request
Feb 4, 2026
Why: We want the buildifier CI job to pass What: - Ran `buildifier -r .` to format all `.bzl` and `BUILD` files. Addresses:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want the buildifier CI job to pass
What:
buildifier -r .to format all.bzlandBUILDfiles.Addresses:
#155