Skip to content

Add back ctu test, it works since CodeChecker 6.26#27

Merged
Szelethus merged 3 commits intoEricsson:mainfrom
furtib:ctu_test
Aug 11, 2025
Merged

Add back ctu test, it works since CodeChecker 6.26#27
Szelethus merged 3 commits intoEricsson:mainfrom
furtib:ctu_test

Conversation

@furtib
Copy link
Copy Markdown
Contributor

@furtib furtib commented Jul 28, 2025

The issue preventing this test from succeeding has been resolved; it shouldn't be skipped.

Requires at least CodeChecker 6.26.0 (tested with 6.25)

@furtib furtib changed the title Add back ctu test, it works with CodeChecker 6.26 Add back ctu test, it works since CodeChecker 6.26 Jul 28, 2025
@Szelethus Szelethus requested review from Szelethus, dkrupp and nettle July 28, 2025 14:02
@Szelethus Szelethus added the bug Something isn't working label Jul 28, 2025
Copy link
Copy Markdown
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to adjust the README file as well, then.

nettle
nettle previously requested changes Jul 29, 2025
Comment thread README.md
@nettle nettle added enhancement New feature or request and removed bug Something isn't working labels Jul 29, 2025
@furtib furtib requested review from Szelethus and nettle July 30, 2025 08:33
Copy link
Copy Markdown
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nettle
Copy link
Copy Markdown
Collaborator

nettle commented Jul 30, 2025

This change is good!
But I think we should submit it at least after CI verification enabled.

@furtib
Copy link
Copy Markdown
Contributor Author

furtib commented Aug 7, 2025

We have CI verification now! @Szelethus, does this conflict with the documentation patch? #13

@furtib furtib requested a review from Szelethus August 11, 2025 05:26
Copy link
Copy Markdown
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We tested interally, and on our RHEL9 machine all tests are passing.

@Szelethus Szelethus dismissed nettle’s stale review August 11, 2025 07:36

CI is now enabled, and all tests are passing.

@Szelethus Szelethus merged commit 102a939 into Ericsson:main Aug 11, 2025
1 check passed
furtib added a commit to furtib/rules_codechecker that referenced this pull request Aug 27, 2025
The issue preventing this test from succeeding has been resolved; it
shouldn't be skipped.

Requires at least CodeChecker 6.26.0 (tested with 6.25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants