fix(windows): align titlebar overlay color with TabBar background#454
Merged
Merged
Conversation
The Windows native titlebar overlay (minimize/maximize/close buttons area) used colors based on --background (sidebar color), which differed from the actual rendered TabBar background: hsl(--muted / 0.5) alpha-composited over hsl(--content-area). For light themes like ocean/forest/slate, this created a clearly visible color seam where the 140px native overlay block didn't blend with the adjacent TabBar. Updated THEME_COLORS to use the pre-computed blend values for each theme, eliminating the visual "cut-off" reported in issue #436. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Windows 下右上角的原生标题栏区域（最小化/最大化/关闭按钮，约 140px 宽）呈现出与左侧 TabBar 颜色不一致的色块，在非深色主题下尤为明显（晴空碧海、森息晨光、云朵舞者等亮色主题）。
Closes #436
根因分析
titlebar-overlay.ts中THEME_COLORS的颜色值参考的是--background（侧边栏色），而不是 TabBar 的实际渲染颜色。TabBar 的实际可见颜色是
hsl(--muted / 0.5)以 alpha 混合到hsl(--content-area)背景上的结果。由于 overlay 颜色与 TabBar 颜色不一致，两个区域之间会出现明显的色差边界。例如晴空碧海亮色主题：
#ecf2f7（--background侧边栏色）#e6eef5（muted/0.5混合到content-area）修复方案
对每个主题预先计算
alpha-composite(hsl(--muted) × 0.5, hsl(--content-area))的结果，将THEME_COLORS更新为与 TabBar 实际渲染色精确匹配的值：#ffffff#fafafa#121212#1c1c1c#ecf2f7#e6eef5#182434#131c26#eff5f1#ecf1ee#212c26#16201b#e3e1dc#e6e4df#1d1b20#1f1c21测试计划
🤖 Generated with Claude Code