fix(diff): add line count guard to prevent large file diff from freezing UI#465
Merged
Conversation
…ing UI When the agent generates large files (e.g., in "visual companion" mode), the Myers diff algorithm O(N*D) in @pierre/diffs blocks the main thread. Skip MultiFileDiff rendering for files over 5000 lines and show a fallback message instead. Closes #459 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_DIFF_LINES = 5000guard inDiffView.tsxbefore renderingMultiFileDiffRoot Cause
@pierre/diffsMultiFileDiffinternally callscreateTwoFilesPatch→diffLines()(Myers O(N×D)) synchronously inuseMemo, blocking the main thread. TheparseDiffOptionstype excludestimeout/maxEditLength, so the underlyingdifflibrary cannot be constrained.Fix
countLines()helper efficiently counts newlines in O(chars)MultiFileDiffand show a clean fallbackMAX_PREVIEW_CHARS = 500_000guard pattern inDiffTabContent.tsxTest Plan
🤖 Generated with Claude Code