Feature: existing secret#86
Closed
alvarogonzalez-packlink wants to merge 2 commits intoEscape-Technologies:mainfrom
Closed
Feature: existing secret#86alvarogonzalez-packlink wants to merge 2 commits intoEscape-Technologies:mainfrom
alvarogonzalez-packlink wants to merge 2 commits intoEscape-Technologies:mainfrom
Conversation
QuentinN42
approved these changes
Mar 19, 2026
Contributor
|
cf. !88 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an option so ESCAPE_API_KEY can be declared using an existing secret.
Use case
When doing IAAC (or maintaining configuration in any kind of repository) we cannot declare secrets on values files. For this, I've added the option of referring to an existing Kubernetes secret that's managed by our secret manager.