Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corona runtime doesn't declare self.boneIndex in any of the timelines. #8

Closed
terrysimons opened this issue Mar 2, 2013 · 4 comments

Comments

@terrysimons
Copy link

I noticed that the Corona runtime doesn't declare self.boneIndex in any of the timelines.

Apparently Lua is forgiving of this? It seems like setting that property on the class is perfectly fine with it not defined?

I think the code would be a little bit easier for someone to follow if this were defined in the classes, even if it's not strictly necessary... thoughts?

Brighid:spine-corona terry$ grep -r boneIndex *
spine/Animation.lua: local bone = skeleton.bones[self.boneIndex]
spine/Animation.lua: local bone = skeleton.bones[self.boneIndex]
spine/Animation.lua: local bone = skeleton.bones[self.boneIndex]
spine/SkeletonJson.lua: local boneIndex = skeletonData:findBoneIndex(boneName)
spine/SkeletonJson.lua: if boneIndex == -1 then error("Bone not found: " .. boneName) end
spine/SkeletonJson.lua: timeline.boneIndex = boneIndex
spine/SkeletonJson.lua: timeline.boneIndex = boneIndex

@terrysimons
Copy link
Author

Also true of the slotIndex variable in the ColorTimeline class.

@terrysimons
Copy link
Author

Also true of the slotIndex variable in the AttachmentTimeline class.

@terrysimons
Copy link
Author

Oops - slotName is used int he AttachemntTimeline class in Corona, but it still isn't defined.

C++ uses slotIndex.

@NathanSweet
Copy link
Member

Seems reasonable. Done, thanks!

pharan added a commit that referenced this issue Dec 30, 2015
Merging with official runtime.
badlogic pushed a commit that referenced this issue Jun 18, 2024
* Add `spine-iOS` SPM package & example app (#1)

* Basic Mesh Rendering (#2)

* Spine C++ Swift Wrapper (#3)

* Load `Atlas` & `SkeletonData` (#4)

Load & dispose `Atlas` & `SkeletonData` from bundled files.

* Generate Swift classes from `spine-cpp-lite.h` (#5)

* Draw `SkeletonData` render commands (#6)

- Use `SkeletonData` render commands in the renderer
- Simple loop for animation support

* Add `BoundsProvider` (#7)

- Implement & support `BoundsProvider` classes
- Introduce alignment and content mode
- Update c to swift script to return optional for find prefixed methods

* Support `SpineController` & `Event` callbacks (#8)

- Support SpineController callbacks
- Support Event callbacks
- Apply tint color in renderer

* Support `DressUp` sample (#9)

- Add `DressUp` sample
- Move SpineViewController to SpineUIView
- Implement SpineUIView export to image

* Remove unused file

* Add `Physics` sample (#10)

- Add `Physics` sample
- Fix offsets in `IKFollowing` sample
- Fix `SpineView` background color

* Add `DebugRendering` sample (#11)

- Add `DebugRendering` sample
- Make `SpineUIView` transparent

* Move remaining files to SPM package (#12)

- Move remaining files to SPM package
- Rename `SpineWrapper` to `SpineCppLite`

* Load assets from different sources (#13)

- Load from bundle, file, http & drawable
- Apply correct blend mode & pma in renderer

* Add `Obj-C` + `UIKit` sample (#14)

- Add `Obj-C` + `UIKit` sample
- Update `Spine` to be usable in Obj-C code base

* Support CocoaPods (#15)

* Metal Best Practices (#16)

- Tripple Buffering
- Buffer Bindings
- Shared Objects

* Annotate functions that should return optional (#17)

* Add option to disable drawing when out of viewport (#18)

- Add option to disable drawing when out of viewport
- Move update clock to controller so multiple views can share it

* Add docs for public Spine classes/methods (#19)

* Fix various regressions (#20)

- Fix retain `SpineController` retain cycle
- Fix issue wehre images were not rendered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants