Skip to content

Refactor multilinear PCS opening#177

Merged
chancharles92 merged 4 commits intomainfrom
pcs-open-refactor-by-170
Jan 13, 2023
Merged

Refactor multilinear PCS opening#177
chancharles92 merged 4 commits intomainfrom
pcs-open-refactor-by-170

Conversation

@chancharles92
Copy link
Copy Markdown
Contributor

@chancharles92 chancharles92 commented Jan 9, 2023

Description

closes: #170


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@chancharles92 chancharles92 requested review from alxiong and mrain January 9, 2023 15:07
alxiong
alxiong previously approved these changes Jan 9, 2023
@chancharles92 chancharles92 requested a review from alxiong January 9, 2023 20:06
@chancharles92 chancharles92 dismissed alxiong’s stale review January 9, 2023 20:06

Delay approval until strengthening tests.

@chancharles92 chancharles92 force-pushed the pcs-open-refactor-by-170 branch from d6817b9 to d1012ac Compare January 9, 2023 21:31
@chancharles92 chancharles92 merged commit 5dc3b1a into main Jan 13, 2023
@chancharles92 chancharles92 deleted the pcs-open-refactor-by-170 branch January 13, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multilinear PCS opening uses too many scalars

2 participants