This repository was archived by the owner on Dec 1, 2020. It is now read-only.
Conversation
Member
|
Definitely want to use the compact build. The amd buiild is not suitable for use on it's own. It should be paired w/ a loader (dojo, require.js, etc) and ideally brought down locally for a custom build.
|
Contributor
Author
|
@tomwayson thanks for feedback and latest commit with 3.15compact. As you suggested, my node version was possibly too new. Rolling back to 0.x helped me run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tomwayson please review. Resolves #156. A couple of notes:
3.15amdand3.15compact. I'd recommend trying out both on the docs site and refreshing pages to see what you think. How should we proceed with what esriLoader defaults to?gulp testis hosed with running protractor tests. My protractor, webdriver-manager, node, java, etc. deps seem to be fine and on my win PATH. Have you seen this occurring on your end? Right whengulp-angular-protractoris starting up. So, I'm submitting this PR but I'd have felt more comfortable with my changes if I could have run this first.