Skip to content
This repository was archived by the owner on Dec 1, 2020. It is now read-only.

JSAPI 3.15#166

Merged
jwasilgeo merged 3 commits intomasterfrom
jsapi315
Nov 30, 2015
Merged

JSAPI 3.15#166
jwasilgeo merged 3 commits intomasterfrom
jsapi315

Conversation

@jwasilgeo
Copy link
Copy Markdown
Contributor

@tomwayson please review. Resolves #156. A couple of notes:

  • Seem to be some timing differences between 3.15amd and 3.15compact. I'd recommend trying out both on the docs site and refreshing pages to see what you think. How should we proceed with what esriLoader defaults to?
  • My gulp test is hosed with running protractor tests. My protractor, webdriver-manager, node, java, etc. deps seem to be fine and on my win PATH. Have you seen this occurring on your end? Right when gulp-angular-protractor is starting up. So, I'm submitting this PR but I'd have felt more comfortable with my changes if I could have run this first.

@tomwayson
Copy link
Copy Markdown
Member

Definitely want to use the compact build. The amd buiild is not suitable for use on it's own. It should be paired w/ a loader (dojo, require.js, etc) and ideally brought down locally for a custom build.

gulp test runs fine for me. I did have a couple failures due to timeouts while using the amd build (as to be expected, it is much slower), but after switching to compact, all tests pass. Try pulling the latest and running the tests.

@jwasilgeo
Copy link
Copy Markdown
Contributor Author

@tomwayson thanks for feedback and latest commit with 3.15compact. As you suggested, my node version was possibly too new. Rolling back to 0.x helped me run gulp test.

jwasilgeo pushed a commit that referenced this pull request Nov 30, 2015
@jwasilgeo jwasilgeo merged commit 72e6791 into master Nov 30, 2015
@jwasilgeo jwasilgeo deleted the jsapi315 branch November 30, 2015 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants